Avoid overwriting dicts.dat if it is unchanged #1647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another concurrency problem that is similar to #1600 and which I hadn't noticed at the time. At the moment,
dicts.dat
is overwritten every time a Python instance accesses an interface for the first time, even if the cache files for this interface already exist anddicts.dat
is already up to date. This causes problems if another Python instance tries to read or writedicts.dat
at the same time. So I changed the code to updatedicts.dat
only if its contents were actually changed, making this far less likely.