Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overwriting dicts.dat if it is unchanged #1647

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

SReicheltPTV
Copy link
Contributor

This fixes another concurrency problem that is similar to #1600 and which I hadn't noticed at the time. At the moment, dicts.dat is overwritten every time a Python instance accesses an interface for the first time, even if the cache files for this interface already exist and dicts.dat is already up to date. This causes problems if another Python instance tries to read or write dicts.dat at the same time. So I changed the code to update dicts.dat only if its contents were actually changed, making this far less likely.

@mhammond
Copy link
Owner

Thanks!

@mhammond mhammond merged commit fc102c6 into mhammond:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants