Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adodbapi: Remove references to outdated mxDateTime #2048

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 21, 2023

Split off from #1990 to make it easier to review in isolation.

Remove obsoleted code and references to mxDateTime, which does not support any recent enough python version. Update time tests accordingly.

@Avasam
Copy link
Collaborator Author

Avasam commented Jul 8, 2023

@vernondcole @mhammond Could I get a review on this?

@vernondcole
Copy link
Collaborator

Visual exam looks good.

Microsoft has removed my freebe Sql Server from Azure, so we can't do an extensive adodbapi test that way. Is there any information I may have missed about getting a database server accessable from CI?

@Avasam Avasam changed the title Remove references to outdated mxDateTime adodbapi: Remove references to outdated mxDateTime Aug 12, 2023
@Avasam Avasam changed the title adodbapi: Remove references to outdated mxDateTime adodbapi: Remove references to outdated mxDateTime Aug 12, 2023
@Avasam Avasam requested a review from vernondcole March 25, 2024 17:41
@Avasam Avasam merged commit 3ce363e into mhammond:main Apr 9, 2024
@Avasam Avasam deleted the remove-mxDateTime branch April 9, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants