Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adodbapi: Remove outdated and unused remote feature #2098

Merged
merged 6 commits into from
Apr 10, 2024
Merged

adodbapi: Remove outdated and unused remote feature #2098

merged 6 commits into from
Apr 10, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Aug 10, 2023 •
edited
Loading

See conversation in #2094

I don't think that the facility has ever been used by anyone other than
myself, and the use case for that is now very outdated.
I am in favor of dropping the entire subsystem as deprecated.

- @vernondcole

This PR removes the adodbapi.remote feature entirely, and properly cleans up all references to it. As well as now unused code and redundant conditions.

@Avasam Avasam mentioned this pull request Aug 10, 2023
Open
@Avasam Avasam changed the title Remove adodbapi remote feature Remove outdated and unused adodbapi remote feature Aug 10, 2023
@Avasam Avasam changed the title Remove outdated and unused adodbapi remote feature adodbapi: Remove outdated and unused remote feature Aug 12, 2023
@Avasam Avasam requested a review from vernondcole March 25, 2024 17:42
vernondcole
vernondcole requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@vernondcole vernondcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what is going on here, but I don't think that changes to 147 files is what you had in mind. I think that this PR is in error.

@Avasam
Copy link
Collaborator Author

Avasam commented Mar 28, 2024

I don't understand what is going on here, but I don't think that changes to 147 files is what you had in mind. I think that this PR is in error.

@vernondcole There's only 10 files changed. 3 of which are removal, and 1 is documentation. Are you confusing this with a different PR ?

vernondcole
vernondcole approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@vernondcole vernondcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Perhaps github showed me the wrong expansion for this? What I see now is not what I saw before.

@Avasam Avasam merged commit cd72712 into mhammond:main Apr 10, 2024
27 checks passed
@Avasam Avasam deleted the Remove-adodbapi-remote-feature branch April 10, 2024 04:32
@Avasam Avasam mentioned this pull request Apr 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vernondcole vernondcole vernondcole approved these changes

Assignees
No one assigned
Labels
adodbapi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avasam @vernondcole