Enhance CredDelete to work with dictionaries #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
approved these changes
Mar 12, 2024
| @@ -82,7 +82,8 @@ BOOL PyWinObject_AsCREDENTIAL_ATTRIBUTE(PyObject *obattr, PCREDENTIAL_ATTRIBUTE | |||
| if (PyUnicode_AsWideChar(obValue, (wchar_t *)attr->Value, nchars) == -1) { | |||
| goto done; | |||
| } | |||
| } else { | |||
| } | |||
There was a problem hiding this comment.
For future reference, please leave the existing conventions alone where you can - I hate this indentation style :)
There was a problem hiding this comment.
I could not agree more with you regarding the indent style.
However, it wasn't me who changed it (not voluntarily at least), but the CLang formatting tool (it was the last place in the file which wasn't compliant). Hmm, will take a look at the spec file to see if this thing (alone) can be changed.
There was a problem hiding this comment.
welp, I gotta admit that consistency enforced by a tool does tend to trump my personal preference, so I guess I'm fine with that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1775.
As a rule of thumb I consider that if there's a pair of functions: a getter and a setter, the latter should work with whatever the former returns. Applied to current situation CredDelete (and maybe others?) should work with a CREDENTIAL structure (converted to a dictionary). In most of the cases that should be the only thing that it should work with, but in this current scenario this doesn't apply.