Turn on strict typing in mypy #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Mar 16, 2024
| orig_new_compiler = ccompiler.new_compiler | ||
| ccompiler.new_compiler = my_new_compiler | ||
|
|
||
| base_compiler = MSVCCompiler |
There was a problem hiding this comment.
Doesn't look like base_compiler was used for anything other than being an alias.
|
@mhammond When you have the time, can you turn on autofixing in https://results.pre-commit.ci/ ? Direct link: https://github.com/apps/pre-commit-ci/installations/new |
Avasam
force-pushed
the
turn-on-strict-typing-in-mypy
branch
from
c656901
to
6a4a4c2
Compare
Avasam
commented
Mar 16, 2024
Comment on lines
+22
to
+24
| ; Class cannot subclass "..." (has type "Any"); (IDEM) | ||
| ; TODO: Use typeshed's types-pywin32 stubs after a few more fixes there | ||
| misc, |
There was a problem hiding this comment.
Avasam
commented
Mar 16, 2024
| @@ -907,7 +908,8 @@ def resolveMUITimeZone(spec): | |||
|
|
|||
|
|
|||
| # from jaraco.util.dictlib 5.3.1 | |||
| class RangeMap(dict): | |||
| # TODO: Update to implementation in jaraco.collections | |||
There was a problem hiding this comment.
Avasam
commented
Mar 16, 2024
Avasam
force-pushed
the
turn-on-strict-typing-in-mypy
branch
from
6a4a4c2
to
b45952f
Compare
Avasam
commented
Mar 16, 2024
Avasam
force-pushed
the
turn-on-strict-typing-in-mypy
branch
6 times, most recently
from
bd20882
to
b0eedf9
Compare
Avasam
force-pushed
the
turn-on-strict-typing-in-mypy
branch
from
b0eedf9
to
153a5fc
Compare
…on-strict-typing-in-mypy
mhammond
approved these changes
Apr 10, 2024
…on-strict-typing-in-mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python_versionto 3.8 to stop warnings about mypy not supporting Python 3.7 (relates to Dropping support for Python 3.7 #2207 )setup.py