Remove trailing whitespaces not handled by black #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use ruff to prevent regressions
Avasam
force-pushed
the
trailing-whitespaces
branch
from
a30642c
to
2ed57c3
Compare
Avasam
commented
Mar 24, 2024
|
I'm actually skipping most of these PRs which introduce ruff into CI, just because I want to think that through some more - as I'm sure you have discovered, I'm not a big fan of overly officious CI, and not entirely convinced issues like trailing whitespace are a such a problem they are worth solving with a big stick. |
mhammond
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran using
ruff check --fix --select=W