Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CredGetSessionTypes support #2232

Merged
merged 2 commits into from
Mar 28, 2024
Merged

CredGetSessionTypes support #2232

merged 2 commits into from
Mar 28, 2024

Conversation

CristiFati
Copy link
Contributor

@CristiFati CristiFati commented Mar 28, 2024

Fixes #2067.

I noticed across the module that GIL is not released during native API calls. Is there a specific reason for that?

Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no good reason the GIL is not release elsewhere.

@mhammond mhammond merged commit 484eeda into mhammond:main Mar 28, 2024
27 checks passed
@Avasam
Copy link
Collaborator

Avasam commented Mar 28, 2024

@CristiFati consider using closing keywords before the issue number when linking to the fixed issue ! So they can be better tracked and not accidentally left open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CredGetSessionTypes is not implemented in win32credmodule.cpp
3 participants