Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MFC redist DLLs not found: prefere corresponding version but accept different version #2248

Merged
merged 1 commit into from
May 27, 2024

Conversation

andreabravetti
Copy link
Contributor

This patch fix the error "MFC redist DLLs not found" building pywin32 on system where the redist version is not the same of the vc tools, which is a normal situation ad not an anomaly.

Previous implementation "ensure corresponding version" if the vc tools version is known, else it accept everything.

This implementation "prefere corresponding version" (if the version is known) but accept different version if the corresponding one is not found and allow to build pywin32 in a lot of situation.

I think that this test for the redist version can be improved a lot, for example taking the latest version with the same major from the vc tools version, but at this stage I made the change as little as possible and as compatible as possible: Where previous version builds normally nothing will change and only where it refused to build the change will take effect and solves the problem.

@andreabravetti
Copy link
Contributor Author

This fix issie #2244

@mhammond mhammond merged commit e80ee20 into mhammond:main May 27, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants