-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adodbapi: Simplify simple functions by using assignments and fix misplaced docstrings #2250
base: main
Are you sure you want to change the base?
Conversation
…api-simple-function-wrappers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this would fulfill the requirements of PEP249 which, if I understand correctly, requires a function here. Maybe it would work right, but feels funny and may be hard to understand.
In any case, the string in the line following the def is a docstring, and if the def is removed then the docstring should become a comment.
@mhammond might weigh in on this.
As far as the docstring goes, there's still some value statically for variables, even though it doesn't end up in the runtime To keep the same |
b245208
to
b445eab
Compare
adodbapi version of #2214