Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assert/AssertionError in tests #2268

Merged
merged 2 commits into from
May 28, 2024
Merged

Use assert/AssertionError in tests #2268

merged 2 commits into from
May 28, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented May 28, 2024 •
edited
Loading

Split from any fix for #1902 to reduce the amount of error = and raise error found.
Works towards enabling reportCallIssue in pyright

mhammond
mhammond approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks.

@Avasam Avasam mentioned this pull request May 28, 2024
Merged
@Avasam Avasam merged commit 800868a into mhammond:main May 28, 2024
27 checks passed
@Avasam Avasam deleted the Use-AssertionError-in-tests branch May 28, 2024 21:21
clin1234 pushed a commit to clin1234/pywin32 that referenced this pull request May 28, 2024
@Avasam @clin1234
Use assert/AssertionError in tests (mhammond#2268)
eece5cc
clin1234 pushed a commit to clin1234/pywin32 that referenced this pull request Jun 7, 2024
@Avasam @clin1234
Use assert/AssertionError in tests (mhammond#2268)
7806a13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond mhammond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avasam @mhammond