Remove temporary win32com.server.policy reexports hack marked for removal over 25 years ago
#2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Remove-temporary-win32com.server.policy-reexports-hack
branch
from
e733ef7
to
c8344f1
Compare
Avasam
force-pushed
the
Remove-temporary-win32com.server.policy-reexports-hack
branch
from
c8344f1
to
bf873c8
Compare
mhammond
approved these changes
Oct 13, 2024
| @@ -14,6 +14,8 @@ https://mhammond.github.io/pywin32_installers.html. | |||
| Coming in build 309, as yet unreleased | |||
| -------------------------------------- | |||
|
|
|||
| * Remove temporary `win32com.server.policy` reexports hack (#2344, @Avasam) | |||
There was a problem hiding this comment.
I don't think there's a need for a changelog entry here - we should only add them for things people might possibly notice.
There was a problem hiding this comment.
Some very old code could reference win32com.server.policy.DispatcherWin32trace or win32com.server.policy.DispatcherTrace. I could make that clearer in the changelog. Or remove the change entry entirely if you still prefer that.
Suggested change
| * Remove temporary `win32com.server.policy` reexports hack (#2344, @Avasam) | |
| * Remove temporary `win32com.server.policy` reexports hack (#2344, @Avasam) | |
| Import `DispatcherWin32trace` and `DispatcherTrace` from `win32com.server.dispatcher` instead. |
There was a problem hiding this comment.
Fair enough, a note makes sense then
mhammond
approved these changes
Oct 13, 2024
Avasam
deleted the
Remove-temporary-win32com.server.policy-reexports-hack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.