Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at handling random testFileTimes test failure in test_win32file.py #2346

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions win32/test/test_win32file.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,16 +227,25 @@ def testFileTimes(self):
)
try:
ct, at, wt = win32file.GetFileTime(f)
self.assertTrue(
ct >= now,
# NOTE (Avasam): I've seen the time be off from -0.003 to +1.11 seconds,
# so the above comment about microseconds might be wrong.
# Let's standardize ms and avoid random CI failures
# https://github.com/mhammond/pywin32/issues/2203
ct = ct.replace(microsecond=0)
at = at.replace(microsecond=0)
wt = wt.replace(microsecond=0)
self.assertGreaterEqual(
ct,
now,
f"File was created in the past - now={now}, created={ct}",
)
self.assertTrue(now <= ct <= nowish, (now, ct))
self.assertTrue(
wt >= now,
self.assertTrue(now <= ct <= nowish, (now, ct, nowish))
self.assertGreaterEqual(
wt,
now,
f"File was written-to in the past now={now}, written={wt}",
)
self.assertTrue(now <= wt <= nowish, (now, wt))
self.assertTrue(now <= wt <= nowish, (now, wt, nowish))

# Now set the times.
win32file.SetFileTime(f, later, later, later, UTCTimes=True)
Expand Down
Loading