Imported ppcoin support #9
Conversation
genesis block was not being yield, so the blocki mhanne#1 was becoming genesis * moved parsing blocks from disk away from the benchmark * added check to make sure block was really stored in the main chain
…dation + add index on txin (prev_out, prev_out_index)
|
Peercoin is in the process to rename itself from "ppcoin" to "peercoin". Maybe we should do that here too before the code is merged. |
|
Cool, seems to be working. Have you tried syncing the whole chain? There aren't many specs for ppcoin (only one in block_spec.rb); if you know about the differences to bitcoin it would be great if you could add some. |
I just tried and it fails. On testnet it download the blocks (there's no checkpoint) but it warns about validation failures.
The main difference is on block validation to handle Proof of Stake. What level of validation is in the scope of this library? Should it validate everything the official client validates? |
|
Ah yes, the checkpoints are expected to be a hash. And it also needs a :max_money value configured or validation will fail. See 4d9185d. No idea if these are the correct values (probably not) but this way it's syncing up to block 6324 at least. |
|
For bitcoin, it is supposed to do all the necessary validations. But it could be useful for peercoin even if there are some rules still missing. You could start by disabling the PoW check so it continues downloading the blockchain, and implement the PoS rules later. |
mhanne
force-pushed
the
master
branch
3 times, most recently
from
85097d6 to
169e590
Compare
mhanne
force-pushed
the
master
branch
3 times, most recently
from
11e0d12 to
e3c308c
Compare
mhanne
force-pushed
the
master
branch
2 times, most recently
from
0e7846f to
e422600
Compare
Imported code from Julian Langschaedel on commit cc107af to make it work on the current master.
All the tests passes, but I don't know how extensive they are.