New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added depth in cm metric #25

Open

andyhedges wants to merge 2 commits into mhansen:main from andyhedges:main

andyhedges commented Nov 11, 2023

No description provided.

andyhedges and others added 2 commits

November 11, 2023 08:50


          Added the depth in cm metric

b51c173


          Merge pull request #1 from andyhedges/oil-depth

a3f5709

Added Depth in cms metric to the existing set

Owner

mhansen commented Nov 13, 2023

Thank you for this contribution. I'm happy to expand the set of metrics here to include depth.

Two comments:

Can you add some tests? See https://github.com/mhansen/rtl_433_prometheus/blob/main/rtl_433_prometheus_test.go. This will help me not break this in future.
Can we use meters, not centimeters? Prometheus conventions are to use "base units (e.g. seconds, bytes, meters - not milliseconds, megabytes, kilometers)" https://prometheus.io/docs/practices/naming/#metric-names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet