Add support for IsDate and IsRegExp #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
reviewed
Jun 25, 2018
src/statement.cc
Outdated
| @@ -3,6 +3,7 @@ | |||
| #include "macros.h" | |||
| #include "database.h" | |||
| #include "statement.h" | |||
| #include <napi.h> | |||
There was a problem hiding this comment.
Do we need to add this. I'm guessing it may already be in one of the include file.s
mhdawson
reviewed
Jun 25, 2018
src/statement.cc
Outdated
| @@ -164,13 +165,17 @@ void Statement::Work_AfterPrepare(uv_work_t* req) { | |||
|
|
|||
| template <class T> Values::Field* | |||
| Statement::BindParameter(const Napi::Value source, T pos) { | |||
| if (source.IsString()/* || source.IsRegExp()*/) { | |||
| Napi::Function date_func = source.Env().Global().Get("Date").As<Function>(); | |||
| Napi::Function regexp_func = source.Env().Global().Get("RegExp").As<Function>(); | |||
There was a problem hiding this comment.
Can we cache these by creating in the Init function.
mhdawson
reviewed
Jun 25, 2018
src/statement.cc
Outdated
| @@ -199,6 +204,8 @@ template <class T> Values::Field* | |||
| template <class T> T* Statement::Bind(const Napi::CallbackInfo& info, int start, int last) { | |||
| Napi::Env env = info.Env(); | |||
| Napi::HandleScope scope(env); | |||
| Napi::Function date_func = env.Global().Get("Date").As<Function>(); | |||
| Napi::Function regexp_func = env.Global().Get("RegExp").As<Function>(); | |||
|
|
|||
mhdawson
reviewed
Jul 9, 2018
src/database.cc
Outdated
| mode = info[pos++].As<Napi::Number>().Int32Value(); | ||
| double orig_val = info[pos].As<Napi::Number>().DoubleValue(); | ||
| double int_val = (double)info[pos].As<Napi::Number>().Int32Value(); | ||
| if (orig_val == int_val) { |
There was a problem hiding this comment.
Did you check if this does the right thing for cases like Number.NEGATIVE_INFINITY
Number.POSITIVE_INFINITY etc?
mhdawson
reviewed
Jul 16, 2018
| //} | ||
| else if (OtherInstanceOf(source.As<Object>(), "RegExp")) { | ||
| std::string val = source.ToString().Utf8Value(); | ||
| return new Values::Text(pos, val.length(), val.c_str()); |
mhdawson
reviewed
Jul 16, 2018
src/statement.cc
Outdated
| if (OtherIsInt(name.As<Number>())) { | ||
| baton->parameters.push_back( | ||
| BindParameter((object).Get(name), name.As<Napi::Number>().Int32Value())); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.