Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for 'data file' and 'datafile' in header when writing NRRD file #103

Merged

Conversation

addisonElliott
Copy link
Collaborator

Standardizes the output by replacing 'datafile' with 'data file'.

The NRRD spec seems to advocate for 'data file' over 'datafile'. There is a minor footnote mentioning that 'datafile' is allowed and 'data file' is used throughout their documentation.

Fixes #97

Standardizes the output by replacing 'datafile' with 'data file'.

The NRRD spec seems to advocate for 'data file' over 'datafile'. There is a minor footnote mentioning that 'datafile' is allowed and 'data file' is used throughout their documentation.
@codecov-io
Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #103 into master will increase coverage by 0.26%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   99.47%   99.73%   +0.26%     
==========================================
  Files           6        6              
  Lines         381      383       +2     
  Branches      123      124       +1     
==========================================
+ Hits          379      382       +3     
+ Misses          1        0       -1     
  Partials        1        1
Impacted Files Coverage Δ
nrrd/writer.py 99.19% <75%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b500fbc...abaad66. Read the comment docs.

@addisonElliott addisonElliott merged commit 6faf838 into mhe:master Nov 16, 2019
@addisonElliott addisonElliott deleted the standardize-datafile-header branch November 16, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to account for both 'datafile' and 'data file'
2 participants