Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy tostring warnings #112

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix numpy tostring warnings #112

merged 1 commit into from
Apr 1, 2021

Conversation

mscheifer
Copy link
Contributor

@mscheifer mscheifer commented Mar 31, 2021

Using the tostring function causes warnings like this starting in numpy 1.19:

DeprecationWarning: tostring() is deprecated. Use tobytes() instead.

The simple fix is to replace them with tobytes which does the same thing.

Closes #110

Using the tostring function causes warnings like this starting in numpy 1.19:

  DeprecationWarning: tostring() is deprecated. Use tobytes() instead.

The simple fix is to replace them with tobytes which does the same thing.
@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #112 (fe29a17) into master (eacf69d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines          391       397    +6     
  Branches       126       126           
=========================================
+ Hits           391       397    +6     
Impacted Files Coverage Δ
nrrd/writer.py 100.00% <100.00%> (ø)
nrrd/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eacf69d...fe29a17. Read the comment docs.

@addisonElliott addisonElliott merged commit d25b1f4 into mhe:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning in nrrd/writer.py with numpy 1.19.0
3 participants