Document that header object given to nrrd.write will be updated with auto generated fields #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the auto generated fields. Also, fixed some minor issues with the docs.
|
@simeks Mind reviewing this when you get a chance? I'm going to go ahead and merge yours now. |
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 6 6
Lines 361 361
Branches 116 116
=======================================
Hits 358 358
Misses 1 1
Partials 2 2
Continue to review full report at Codecov.
|
Looks good! Makes more sense now when you actually see it in the docs 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some minor fixes to the docs that were causing problems.