Fix test compilation errors on Windows #144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable EVFILT_PROC as this is not supported. * Initialize kevent() timeouts using an older syntax. * Use Sleep() instead of usleep(). * Disable test_transition_from_write_to_read(). * Emulate the POSIX API for shutdown(2) and pipe(2).
|
The tests don't actually run successfully, but at least they compile. |
arr2036
reviewed
Jun 21, 2022
|
|
||
| EV_SET(&kev, 0, EVFILT_LIBKQUEUE, EV_ADD, NOTE_VERSION, 0, NULL); | ||
| if (kevent(ctx->kqfd, &kev, 1, &receipt, 1, &(struct timespec){}) != 1) { | ||
| if (kevent(ctx->kqfd, &kev, 1, &receipt, 1, &ts) != 1) { |
There was a problem hiding this comment.
Windows still doesn't support C11?!
There was a problem hiding this comment.
I think it still doesn't support compound literals. I even tried enabling the latest conforming preprocessor:
neheb
reviewed
Jun 26, 2022
| #define SHUT_RDWR SD_BOTH | ||
|
|
||
| /* Emulate the POSIX pipe(2) interface */ | ||
| #define pipe(x) _pipe(x, 512, 0) |
There was a problem hiding this comment.
I'd wrap a lot of these in ifdef _MSC_VER
MinGW supports a lot of this, including pthread.
neheb
reviewed
Jun 26, 2022
| @@ -16,6 +16,12 @@ | |||
|
|
|||
| #include "common.h" | |||
|
|
|||
| #if defined(_WIN32) | |||
arr2036
force-pushed
the
master
branch
12 times, most recently
from
6eba1b5
to
24f20f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.