fix: backport the fix for the return value of #deep_transform_keys #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenrixon
approved these changes
Dec 30, 2022
mhenrixon
added a commit
that referenced
this pull request
Jul 14, 2023
* Fix active worker detection by using correct keys (#756) Rename keys from :workers to :work since that's correct name set in Redis * chore(lint): fix linter issues * fix(unlock): ensure callback and unlock (#771) * chore(deps): update gems (solargraph is awesome) * fix(unlock): ensure unlock and callback runs * chore(lint): lint'em real good # Conflicts: # .github/workflows/rspec.yml # myapp/.tool-versions * fix: backport the fix for the return value of #deep_transform_keys (#750) Backport fix the return value of #deep_transform_keys * Hide lock info debug suggestion on lock page if it's already enabled. (#763) only show lock info suggestion if value is not already on * chore(v7): backport fixes from v8 * chore(ci): backport ci changes from v8 --------- Co-authored-by: Dominik Szromik <dodox360@gmail.com> Co-authored-by: Egor Romanov <unsaidxpl@gmail.com> Co-authored-by: Jeremiah <jeremiahchurch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
Hash#deep_transform_keyswas fixed in Rails a while ago, but is still not up-to-date insidekiq-unique-jobs, returning unexpected instance class when you call it on descendants ofHashlikeActiveSupport::HashWithIndifferentAccess. Futhermore, the gem is able to monkey-patchHashimplementation and break the method behavior if it gets loaded beforeActiveSupport::HashWithIndifferentAccess.The original fix: rails/rails@f5e5976