Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock to item when lock_type is pulled from Job class sidekiq options #786

Merged
merged 2 commits into from
May 27, 2023
Merged

Add lock to item when lock_type is pulled from Job class sidekiq options #786

merged 2 commits into from
May 27, 2023

Commits on May 26, 2023

  1. Add lock to item when lock_type is pulled from Job class sidekiq options 

    For jobs that are queued without the lock options, to a Job class that has `lock` option set in the `sidekiq_options` will still go through the SidekiqUniqueJobs server middleware, but won't have `lock` set on the item the entire time.
This doesn't seem to be affecting the locking or unlocking of jobs, however it is affecting the logging_context because the Middleware LogContext expects the item[LOCK] to have a value.
    @ttstarck
    ttstarck committed May 26, 2023
    Configuration menu
    Copy the full SHA
    cfe59ea View commit details
    Browse the repository at this point in the history

  2. address Rubocop issues

    @ttstarck
    ttstarck committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a671980 View commit details
    Browse the repository at this point in the history