Skip to content

[FEAT]: Reformat output and refactor code #19

Closed
@mheob

Description

@mheob

Description

The output of a release line does not have the style we want.

For example


-   add `eslint-plugin-simple-import-sort` and `eslint-plugin-import` ESLint plugins -->
    ([#103](https://github.com/mheob/config/pull/103)) by [@mheob](https://github.com/mheob)
  • add eslint-plugin-simple-import-sort and eslint-plugin-import ESLint plugins -->
    (#103) by @mheob

should look like this

- add `eslint-plugin-simple-import-sort` and `eslint-plugin-import` ESLint plugins --> ([#103](https://github.com/mheob/config/pull/103)) by [@mheob](https://github.com/mheob)
  • add eslint-plugin-simple-import-sort and eslint-plugin-import ESLint plugins --> (#103) by @mheob

Additional Information

Besides the changes of the output we could improve the code a bit.

For example should the getUserLink function return only the userLink without the by prefix:

function getUserLink(usersFromSummary: string[], user?: string): string | undefined {
const userLink =
usersFromSummary.length > 0
? usersFromSummary
.map((userFromSummary) => `[@${userFromSummary}](https://github.com/${userFromSummary})`)
.join(', ')
.trim()
: user;
return userLink ? `by ${userLink}` : undefined;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestrefactorRestyle or refactor the code base

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions