Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add periodic state save. #1028

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Add periodic state save. #1028

merged 3 commits into from
Nov 23, 2020

Conversation

Tohman21
Copy link
Contributor

Resolve #803

ghedb
ghedb reviewed Oct 20, 2020
View reviewed changes
Copy link

@ghedb ghedb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not super familiar with Tornado but everything looks good to me from a logical perspective.

I just have one comment, does the word timeout really make sense?

Maybe state save interval would be more clear?

@ghedb
Copy link

ghedb commented Oct 20, 2020 •
edited
Loading

Im not super familiar with Tornado but everything looks good to me from a logical perspective.

I just have one comment, does the word timeout really make sense?

Maybe state save interval would be more clear?

Wait a sec, is it a timeout? The tornado docs seem a bit unclear.

The callback is called every callback_time milliseconds. Note that the timeout is given in milliseconds, while most other time-related functions in Tornado use seconds.

@Tohman21
Copy link
Contributor Author

Im not super familiar with Tornado but everything looks good to me from a logical perspective.

I just have one comment, does the word timeout really make sense?

Maybe state save interval would be more clear?

I agree that the word "interval" is clearer than "timeout"

@mher mher merged commit 1825d04 into mher:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghedb ghedb ghedb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Periodic state save to DB
3 participants
@Tohman21 @ghedb @mher