Use celery app timezone #1351
Open
Use celery app timezone #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1163 #1132
The task started and received times in the task table are derived from the raw celery events which provide times as number of seconds passed since the epoch.
flower/flower/views/tasks.py
Line 117 in 58136bf
This code takes
timezoneinto account but notenable_utc.https://docs.celeryq.dev/en/stable/userguide/configuration.html#time-and-date-settings
Instead of using the time and date settings from the celery configuration directly, this PR proposes to use the timezone provided by the celery app
https://github.com/celery/celery/blob/8f389997887232500d4aa1a2b0ae0c7320c4c84a/celery/app/base.py#L1360
This allows using an explicit timezone (e.g.
timezone = "Europe/Paris") or the local timezone (enable_utc = False).