Allow specification of license in settings file for linux deb files #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I haven't tested it, but from reading the code could it be that |
We are checking here that license exists in the JSON, but there is the situation whereby license exists in the file, but has not yet been specified, this may cause a failure I suppose. I'll update this PR to be a little more robust. |
Spikedoody1
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, output from
dpkg --info AppName.debspecifies that the license of the package to be installed is unknown. This small change will allow users to specify the license in the deb file, based on a variable in a config file.A user of fbs would add the line
"license": "GPL"or similar in theirlinux.jsonto use this feature.