Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major: use please-upgrade-node #444

Open
brodycj opened this issue May 19, 2020 · 0 comments
Open

major: use please-upgrade-node #444

brodycj opened this issue May 19, 2020 · 0 comments

Comments

@brodycj
Copy link
Collaborator

brodycj commented May 19, 2020

https://www.npmjs.com/package/please-upgrade-node

to enforce the Node.js engine requirement more strongly (in lib/jasmine-node/index.js)

should be done together with adding engines field as I had proposed in PR #443

should be part of new major release discussed in #436

Thanks to Prettier project where I first saw this in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant