Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT MAJOR WIP] Add Node.js engines field which drops old Node.js versions #443

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brodycj
Copy link
Collaborator

@brodycj brodycj commented May 21, 2019

This should be in an another new major release as tracked in #436, drops support for Node.js pre-8.0

Copy link
Collaborator Author

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO items

@@ -13,6 +13,9 @@
],
"author": "Misko Hevery <misko@hevery.com>",
"license": "MIT",
"engines": {
"node": ">= 8.0.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"node": ">= 8.0.0"
"node": ">= 10"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and use npm:please-upgrade-node to enforce minimum Node.js requirement more strongly (#444)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant