Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jasmine-growl-reporter to fix critical vulnerability in Jasmine2.0 #440

Open
wants to merge 1 commit into
base: Jasmine2.0
Choose a base branch
from

Conversation

beckyconning
Copy link
Contributor

No description provided.

@brodycj
Copy link
Collaborator

brodycj commented May 21, 2019

Thanks @beckyconning. Considering that the Jasmine2.0 branch was already abandoned (see [1]), this proposal will probably not be integrated.

[1] https://github.com/mhevery/jasmine-node#jasmine

@beckyconning
Copy link
Contributor Author

In an ideal world everyone would update to the latest software regardless of breaking changes. However time and labour aren't free.

This seems to be a case where changing two characters will improve the security of legacy software.

Why prevent such a change?

Copy link
Collaborator

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://github.com/AlphaHydrae/jasmine-growl-reporter#compatibility:

v2.* drops support for Node.js 0.12 and older

But from here we can see that the Jasmine2.0 branch supports Node.js back to 0.10.

Breaking change needs to be in a new major version.

If you can convince jasmine-growl-reporter to resolve the vulnerability without breaking on Node.js 0.10, I would be happy to make this one update on the Jasmine2.0 branch.

A side point is that legacy software is not free to support from the open-source side. I think we would need both some more active contributors and active backing from something like Tidelift to make this kind of legacy software support practical.

My apologies for the difficulties with the critical vulnerability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants