Add key that was removed at some point #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhilbrunner fyi |
mhilbrunner
approved these changes
Jul 13, 2024
|
Typical Deutsch indeed. Thanks for the fix, the ping and also the digging in the first place :) Released version 3.2.1 with this change: https://github.com/mhilbrunner/foundryvtt-dnd5e-lang-de/releases/tag/3.2.1 |
|
Looked through my stuff, was 100% my oopsie from my last commit. |
|
No worries, mistakes happen :) Thanks for contributing in the first place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the NPC Character sheets the "Proficiency" on the top right was missing a key with a translation. After some digging inside the code and previous commits I noticed that a custom key is set because in German the value would be too long (typisch Deutsch). The key was already there once but got removed. So here it is again 🙂
Didn't test it but the key is still the same inside the code, so should be fine...