-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SvelteKit 1.0.0-next.202 / Vite 2.7 issue #54
Comments
Add svelte to package.json. Fixes #54
Interestingly, I get this same error when using the new sveltekit version even though it has |
Hmm. It’s currently working for me and published/deployed an update to LayerChart with it. I know on my primary application I had layercake in optimizeDeps within svelte.config.js which was still giving me the error (or similar) until I removed it, although I don’t see that in your kit branch at all. I was just calling it a night (typing on my phone) but if you’re still having issues I can take a look tomorrow sometime. |
Nope not urgent and it seems to be working now. My next step is to see if it works with the layercake.graphics examples but that will be for another day. |
After upgrading to SvelteKit
1.0.0-next.202
which includes Vite 2.7, I receive the following when importing LayerCake:While I'm not 100% certain, I believe the heuristic changed with Vite 2.7 to detect a svelte package, and the best tell now is to include a
svelte
property inpackage.json
(along withmain
/exports
). If using SvelteKit to build packages, runningsvelte-kit package
now sets this for you. This PR along with the associated issue and code provides some additional info.Sending a PR your way...
The text was updated successfully, but these errors were encountered: