Add type information for mousemove event #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a JSDoc typecast for the 'layerX'/'layerY' values.
mhkeller
reviewed
Aug 26, 2024
src/_components/QuadTree.html.svelte
Outdated
|
|
||
| const xLayerKey = /** @type {'layerX'|'layerY'} */ (`layer${x.toUpperCase()}`); | ||
| const yLayerKey = /** @type {'layerX'|'layerY'}*/ (`layer${y.toUpperCase()}`); | ||
| console.log(evt.x, evt.y); |
There was a problem hiding this comment.
Ooop, sory! Thanks for the merge!
|
That makes sense. Ya I tend to find those inline types harder for newcomers to read but seems like this is the best solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type information for the mousemove event in the Quadtree components. The error was:
This also adds a JSDoc typecast for the 'layerX'/'layerY' values which probably is an example of those type annotations you didn't like so much (and me neither).
I didn't find another way to let the checking accept the uppercase conversion in
layer${x.toUpperCase()as a type of'layerX'|'layerY'.