Modified the GuessDelimiter function. #593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the GuessDelimiter function, so that a new delimiter is chosen as best if its delta value is higher than the current highest. Added a testcase for decimal values with comma as decimal separator and pipes as delimiter. But i couldnt ran the tests as i dont have a node interpreter installed, so i am not sure if the other tests dont break now.
|
Hi, thanks for the PR I see you've added a new test-cases.js file, you should modify the tests-cases.js file in the test folder. |
Added testcase with pipes and decimal values with commas as decimal separator.
|
We use tabs for formating and you just added some code with spaces. This breaks the linter , could you please fix it? |
|
I will prefer to include only in this pull request the changes related to the GuessDelimiter function and move all the other code styling changes in a separate Pull Request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the GuessDelimiter function, so that a new delimiter is chosen as best if its delta value is higher than the current chosen.
Added a testcase for decimal values with comma as decimal separator and pipes as delimiter.
(Which should mimic the following test data:
a|3,4|b
c|3,4|d
)
But i couldnt ran the tests because i dont have a node interpreter installed, so i am not sure if the other tests break, altough the test data mentioned above now produces the correct result).