Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case for issue 738: Skip lines future. #746

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test case for issue 738: Skip lines future. #746

wants to merge 2 commits into from

Conversation

DamirKh
Copy link

@DamirKh DamirKh commented Nov 19, 2019

@DamirKh
Copy link
Author

DamirKh commented Nov 19, 2019

Yep! I have only add a test case, but have no much experience yet to complete implementation.

@pokoli
Copy link
Collaborator

pokoli commented Nov 19, 2019

Ok, this is a first step. Thank you.

I've seen there are some linting errors related to your code. See:

https://travis-ci.org/mholt/PapaParse/jobs/613869900?utm_medium=notification&utm_source=github_status

Could you please fix them?

@DamirKh
Copy link
Author

DamirKh commented Nov 21, 2019

Sorry for force-pushed to my branch. That was a surprise for me with automatic pull request to You brunch. I will never do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamirKh @pokoli