Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7z should have Archive method #360

Closed
drwpeng opened this issue Dec 8, 2022 · 3 comments · Fixed by #364
Closed

7z should have Archive method #360

drwpeng opened this issue Dec 8, 2022 · 3 comments · Fixed by #364
Labels
feature request

Comments

@drwpeng
Copy link

drwpeng commented Dec 8, 2022

7z should implement Archive or other methods, which makes the Identity method unable to determine the file type
@mholt
Copy link
Owner

mholt commented Dec 8, 2022

That requires that a 7z writer be implemented in pure Go first, which I haven't found.

@mholt mholt changed the title 7z requires Archive method 7z should have Archive method Dec 8, 2022
@drwpeng
Copy link
Author

drwpeng commented Dec 9, 2022

It seems that there is no pure Go implementation at present, but you can use the empty method like rar

@mholt
Copy link
Owner

mholt commented Dec 9, 2022

Oh, right! That's true, I guess we should do that at least.

nikolaymatrosov pushed a commit to nikolaymatrosov/archiver that referenced this issue Jan 7, 2023
add Archive method to SevenZip. close mholt#360
0740add
@nikolaymatrosov nikolaymatrosov mentioned this issue Jan 7, 2023
Merged
mholt pushed a commit that referenced this issue Jan 10, 2023
@nikolaymatrosov
add Archive method to SevenZip. close #360 (#364)
f1ef6eb 
Co-authored-by: Nikolay Matrosov nikolay.matrosov@gmail.com <nikthespirit@yandex-team.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add Archive method to SevenZip nikolaymatrosov/archiver
2 participants
@mholt @drwpeng