This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 390
Fixes Tar.Extract when extracting hardlinked files #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This chance relativizes the Linkname on tar headers when extracting hardlinked files. This change also adds a couple of tests around the Tar.Unarchive and Tar.Extract functions.
Closed
Closed
Was this merged to master? It looks like it just went to the |
Oops, indeed. Merged into master now. |
cheers! |
UPDATEIt looks like it reached the master branch under a different commit id (f426e42 -> 9ea51e7). However, the original test fails from #152 under arc 3.3.0 that it was intended to fix (see failure output below). I've opened #213 for this.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by @gus - I would like to somehow integrate your change here with regards to #153.
This chance relativizes the Linkname on tar headers when extracting
hardlinked files.
This change also adds a couple of tests around the Tar.Unarchive and
Tar.Extract functions.