-
-
Notifications
You must be signed in to change notification settings - Fork 390
Add CI check to ensure module definition is correct #198
Conversation
Fail verification if "go mod tidy" results in any modifications to go.mod or go.sum.
This ensures that "go mod tidy" has been run before code has been pushed by failing CI verification if "go mod tidy" causes any modifications to "go.mod" or "go.sum". This would have caught the issue introduced by 14b2737. The CI task for this PR currently fails this new check due to the commit referenced above -- it should be resolved once #197 is merged and this PR is updated to include it. This manual diff after running "go mod tidy" is the best that can be done until golang/go#27005 is implemented/available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool idea, thanks! We'll try it out.
Should we test this by merging master into this branch now that #197 is merged? |
Interesting, it looks like the redirect diff command (
(1) is the more "correct" approach, but will take longer since I'll have to iterate against this Azure environment and will mostly just be Googling and trying different things until I can get it to work :) |
This reverts commit b7d8b0f.
OK, got this to work on the Windows image as well with only modifications to the CI file -- should be ready. |
Awesome, thanks for the effort! 👍 |
Fail verification if "go mod tidy" results in any modifications
to go.mod or go.sum.