This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Add ArchiveAsync; context no longer optional #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following Go best-practices. Zip and Tar now support ArchiveAsync, which reads files from a channel instead of a slice.
|
Merging, as the feedback from @ncw out-of-band is "That interface looks perfect and exactly what rclone needs" -- we can tweak it later if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by rclone/rclone#2815.
Allows creating an archive by sending files down a channel rather than needing to pre-build a list of all the files up front. This is useful for efficiently creating an archive when reading a sequential stream. I think.