zip: fix File.Open not working if called after zip.Extract completes #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zip.Extract method creates a closure for the File.Open function pointer sent to the handler method. Unfortunately it uses the same File for each call to the handler function which means that if the caller stores the File objects and uses them after Extract has returned then each File.Open function pointer will open the same object. This is easily fixed by making sure that each iteration of the Extract loop uses a new File variable.
|
I found this bug when working on the rclone backend for the archiver: See rclone/rclone#2815 Yes this is a lovely example of a classic Go gotcha! |
mholt
approved these changes
Feb 1, 2023
|
Memo to self: I don't think this is needed after Go 1.22 anymore: https://tip.golang.org/doc/go1.22#language |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zip.Extract method creates a closure for the File.Open function
pointer sent to the handler method.
Unfortunately it uses the same File for each call to the handler
function which means that if the caller stores the File objects and
uses them after Extract has returned then each File.Open function
pointer will open the same object.
This is easily fixed by making sure that each iteration of the Extract
loop uses a new File variable.