Log rate limited IPs

[jakanaka]

I want to log which IP's are rate limited with date and stuff. Is it already possible now?

[mholt]

Good q -- we don't currently emit logs when a rate limit has been reached.

What would you like to have, specifically?

cf.

caddy-ratelimit/handler.go

Line 200 in 89a7fec

func (h *Handler) rateLimitExceeded(w http.ResponseWriter, repl *caddy.Replacer, zoneName string, wait time.Duration) error {

[jakanaka]

Good q -- we don't currently emit logs when a rate limit has been reached.

What would you like to have, specifically?

cf.

caddy-ratelimit/handler.go

Line 200 in 89a7fec

func (h *Handler) rateLimitExceeded(w http.ResponseWriter, repl *caddy.Replacer, zoneName string, wait time.Duration) error {

for me, the time, and the client ip should be enough, it will be even better if it is possible give each ip some sort of reputation based on how frequently it gets rate limited and based on that block that ip for longer time or something, or maybe add how many times it got rate limited

[mholt]

Added in 3d68475 -- let me know if that doesn't work for you!

[francislavoie]

Does this only log the first time the limit is hit, or on every request after? Could be quite noisy and add pressure if they're hitting fast, no?

[mholt]

Log sampling can be configured to tame eccentric logs. But yeah we don't keep any state as to whether it's a first hit or not.