Resolve unsubscriptable-object pylint errors

mhostetter · Dec 11, 2022 · 62bf749 · 62bf749
1 parent 0c7392d
commit 62bf749
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -96,7 +96,6 @@ disable = [
     "too-many-lines",
     "too-many-locals",
     "unneeded-not",
-    "unsubscriptable-object",  # pylint doesn't understand metaclass properties
 ]
 min-similarity-lines = 100
 max-line-length = 140

diff --git a/src/galois/_fields/_array.py b/src/galois/_fields/_array.py
@@ -597,7 +597,8 @@ def arithmetic_table(
 
         if cls.element_repr == "power":
             # Order elements by powers of the primitive element
-            x_default = np.concatenate((np.atleast_1d(cls(0)), cls.primitive_element ** np.arange(0, cls.order - 1, dtype=cls.dtypes[-1])))
+            dtype = cls.dtypes[-1]  # pylint: disable=unsubscriptable-object
+            x_default = np.concatenate((np.atleast_1d(cls(0)), cls.primitive_element ** np.arange(0, cls.order - 1, dtype=dtype)))
         else:
             x_default = cls.elements
         y_default = x_default if operation != "/" else x_default[1:]
@@ -1366,7 +1367,8 @@ def field_trace(self) -> FieldArray:
             subfield = field.prime_subfield
             p = field.characteristic
             m = field.degree
-            conjugates = np.power.outer(x, p ** np.arange(0, m, dtype=field.dtypes[-1]))
+            dtype = field.dtypes[-1]  # pylint: disable=unsubscriptable-object
+            conjugates = np.power.outer(x, p ** np.arange(0, m, dtype=dtype))
             trace = np.add.reduce(conjugates, axis=-1)
             trace = subfield._view(trace)
 

diff --git a/src/galois/_fields/_meta.py b/src/galois/_fields/_meta.py
@@ -328,7 +328,7 @@ def squares(cls) -> FieldArray:
         """
         x = cls.elements
         is_square = x.is_square()
-        return x[is_square]
+        return x[is_square]  # pylint: disable=unsubscriptable-object
 
     @property
     def non_squares(cls) -> FieldArray:
@@ -360,7 +360,7 @@ def non_squares(cls) -> FieldArray:
         """
         x = cls.elements
         is_square = x.is_square()
-        return x[~is_square]
+        return x[~is_square]  # pylint: disable=unsubscriptable-object
 
     @property
     def is_prime_field(cls) -> bool: