Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add galois.typing subpackage #339

Merged
merged 6 commits into from
Apr 16, 2022
Merged

Add galois.typing subpackage #339

merged 6 commits into from
Apr 16, 2022

Conversation

mhostetter
Copy link
Owner

No description provided.

@mhostetter
Remove numba from inter-Sphinx mapping
7dcaa30 
It was causing issues when linking to `numpy` functions
@mhostetter mhostetter added documentation Improvements or additions to documentation typing Related to type hints labels Apr 16, 2022
@mhostetter mhostetter force-pushed the typing-subpackage branch 4 times, most recently from a9f5286 to 8897b18 Compare April 16, 2022 10:39
@mhostetter
Remove support for Python 3.6
fc5cb76 
This is required to support type hint forward references with `from __future__ import annotations`. Unfortunately, there is no workaround for Python 3.6.
@codecov
Copy link

codecov bot commented Apr 16, 2022 •
edited
Loading

Codecov Report

Merging #339 (afed9c4) into master (0c34f4f) will decrease coverage by 0.05%.
The diff coverage is 90.35%.

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   93.15%   93.09%   -0.06%     
==========================================
  Files          39       40       +1     
  Lines        5375     5332      -43     
==========================================
- Hits         5007     4964      -43     
  Misses        368      368
Impacted Files Coverage Δ
galois/_fields/_gf2.py 72.72% <ø> (ø)
galois/_modular.py 93.42% <ø> (ø)
galois/_polymorphic.py 98.83% <ø> (ø)
galois/_polys/_functions.py 100.00% <ø> (ø)
galois/_polys/_irreducible.py 100.00% <ø> (ø)
galois/_polys/_primitive.py 99.19% <ø> (ø)
galois/_prime.py 91.96% <ø> (ø)
galois/_fields/_array.py 93.59% <76.71%> (-0.30%) ⬇️
galois/_lfsr.py 84.37% <92.59%> (-1.14%) ⬇️
galois/__init__.py 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c34f4f...afed9c4. Read the comment docs.

@mhostetter mhostetter merged commit 1e23c36 into master Apr 16, 2022
@mhostetter mhostetter deleted the typing-subpackage branch April 16, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation typing Related to type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhostetter