Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return int from Poly.degree #361

Merged
merged 2 commits into from
May 16, 2022
Merged

Always return int from Poly.degree #361

merged 2 commits into from
May 16, 2022

Commits on May 16, 2022

  1. Always return int from Poly.degree 

    Fixes #360. In certain circumstances a `np.int64` was returned from `Poly.degree`. When performing irreducibility checks and computing `q**m`, if either `q` or `m` wasn't an `int` the arithmetic could overflow and the irreducibility check became erroneous.
    @mhostetter
    mhostetter committed May 16, 2022
    Configuration menu
    Copy the full SHA
    197c28e View commit details
    Browse the repository at this point in the history

  2. Add additional unit test

    @mhostetter
    mhostetter committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e9a56d4 View commit details
    Browse the repository at this point in the history