Fix array sizing in PLU decomposition

[mhostetter]

Fixes #476.

# bug_476.py
import numpy as np

import galois

GF = galois.GF(2)

A = GF(
    [
        [1, 0, 0, 0, 0, 1],
        [1, 1, 1, 1, 0, 1],
        [1, 0, 0, 0, 0, 0],
        [0, 1, 0, 0, 0, 0],
        [0, 0, 1, 0, 0, 0],
        [0, 0, 0, 1, 0, 0],
        [0, 0, 0, 0, 1, 0],
        [0, 0, 0, 0, 0, 1],
    ]
)
print(f"A = \n{A}")

P, L, U = A.plu_decompose()
print(f"P = \n{P}")
print(f"L = \n{L}")
print(f"U = \n{U}")

PLU = P @ L @ U
print(f"PLU = \n{PLU}")
print(np.array_equal(A, PLU))

$ python3 bug_476.py
A = 
[[1 0 0 0 0 1]
 [1 1 1 1 0 1]
 [1 0 0 0 0 0]
 [0 1 0 0 0 0]
 [0 0 1 0 0 0]
 [0 0 0 1 0 0]
 [0 0 0 0 1 0]
 [0 0 0 0 0 1]]
P = 
[[1 0 0 0 0 0 0 0]
 [0 1 0 0 0 0 0 0]
 [0 0 0 0 0 1 0 0]
 [0 0 1 0 0 0 0 0]
 [0 0 0 1 0 0 0 0]
 [0 0 0 0 0 0 1 0]
 [0 0 0 0 1 0 0 0]
 [0 0 0 0 0 0 0 1]]
L = 
[[1 0 0 0 0 0 0 0]
 [1 1 0 0 0 0 0 0]
 [0 1 1 0 0 0 0 0]
 [0 0 1 1 0 0 0 0]
 [0 0 0 0 1 0 0 0]
 [1 0 0 0 0 1 0 0]
 [0 0 0 1 0 0 0 0]
 [0 0 0 0 0 1 0 1]]
U =
[[1 0 0 0 0 1]
 [0 1 1 1 0 0]
 [0 0 1 1 0 0]
 [0 0 0 1 0 0]
 [0 0 0 0 1 0]
 [0 0 0 0 0 1]
 [0 0 0 0 0 0]
 [0 0 0 0 0 0]]
PLU =
[[1 0 0 0 0 1]
 [1 1 1 1 0 1]
 [1 0 0 0 0 0]
 [0 1 0 0 0 0]
 [0 0 1 0 0 0]
 [0 0 0 1 0 0]
 [0 0 0 0 1 0]
 [0 0 0 0 0 1]]
True

[mhostetter]

@davikrehalt Can you install and test this branch? I believe I have a fix in place.

$ python3 -m pip uninstall galois
$ python3 -m pip install git+https://github.com/mhostetter/galois.git@fix-476

[codecov]

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (db0fde5) 96.33% compared to head (afa1572) 96.33%.

Additional details and impacted files

@@              Coverage Diff               @@
##           release/0.3.x     #477   +/-   ##
==============================================
  Coverage          96.33%   96.33%           
==============================================
  Files                 46       46           
  Lines               5833     5833           
==============================================
  Hits                5619     5619           
  Misses               214      214           

Impacted Files	Coverage Δ
src/galois/_domains/_linalg.py	95.58% <87.50%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[davikrehalt]

Yes it works for me!

[mhostetter]

Sorry for the delay in merging this. It is set to be released in 0.3.4.

Until then, you can install it via:

$ python3 -m pip uninstall galois
$ python3 -m pip install git+https://github.com/mhostetter/galois.git@release/0.3.x