Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes deprecation warnings from numpy 1.25 #492

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

iyanmv
Copy link
Contributor

@iyanmv iyanmv commented Jul 6, 2023

Related to #491.

Not sure if this affects older supported versions, and it's also not that easy for me to check locally, so let's see with the Github CI.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a3c2ce2) 96.33% compared to head (82822aa) 96.33%.

❗ Current head 82822aa differs from pull request most recent head 0bea611. Consider uploading reports for the commit 0bea611 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           release/0.3.x     #492   +/-   ##
==============================================
  Coverage          96.33%   96.33%           
==============================================
  Files                 46       46           
  Lines               5842     5842           
==============================================
  Hits                5628     5628           
  Misses               214      214           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mhostetter
Copy link
Owner

I know what's going on with the docs failing to build. It's from a breaking change in pydantic that affected sphinx-immaterial.

I'll submit a PR to fix the docs and merge it to release/0.3.x. Then you can rebase off of that.

@iyanmv
Copy link
Contributor Author

iyanmv commented Jul 6, 2023

I know what's going on with the docs failing to build. It's from a breaking change in pydantic that affected sphinx-immaterial.

Good because I was totally lost 😅

@mhostetter
Copy link
Owner

Ok, you should be able to rebase off of release/0.3.x now and your build should pass.

Starting with Numpy 1.25, only ndim-0 arrays are treated as scalars
instead of all arrays of size 1 were treated as scalars.
@iyanmv iyanmv changed the base branch from master to release/0.3.x July 6, 2023 22:40
@mhostetter
Copy link
Owner

Sweet! Is this good to merge now? I'm guessing we'll do another PR for full Numba 0.58 support?

@iyanmv
Copy link
Contributor Author

iyanmv commented Jul 7, 2023

Yes, I think so.

@mhostetter mhostetter merged commit 6a3e2c5 into mhostetter:release/0.3.x Jul 7, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants