Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a perquisite to fixing an issue in the radiotherm component of HASS
The problem is, the radiotherms have pretty unreliable networking. Resulting in timeouts in about 1% of requests. By default though, the urllib has a really long timeout, which results in the HASS component crapping itself. So we need a way to override the default tiemout, which requires this fix.
For some further context, I did some timing tests against my CT50, and saw the following:
4 seconds seemed a reasonable default for use on local networks; happy to leave that at
urllib
's default if consensus is that makes more sense.