Use jquery text instead of html. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Before I merge it in, I'm just curious if you could share an example of what an svg text element would look like that wouldn't work with the existing code. I'm pretty sure I'm going to merge regardless, I'm just curious for the sake of learning. 😄 Thanks! |
|
hey! thanks for the response. here's a small example: https://gist.github.com/benrudolph/7830486 |
|
Cool, thanks! Tried it on jsfiddle before and after the change, and I see what you mean now. |
mhuggins
added a commit
that referenced
this pull request
Dec 6, 2013
Use jquery text instead of html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jquery
htmlfunction does not work for svg text elements which was my use case. Since we should never be displaying html anyways I thought this could make the library slightly more multifunctional. Great plugin btw, really enjoy it.