Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 7.1 support, update dependencies #6

Merged
merged 3 commits into from
Nov 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
language: php

php:
- 7.1
- 7.2
- 7.3

env:
matrix:
Expand All @@ -15,5 +15,5 @@ before_script:
script:
- composer run build

after_script:
- composer run coveralls
after_success:
- travis_retry php vendor/bin/php-coveralls -v
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class User

Requirements
------------
Works with PHP 7.1 or higher.
Works with PHP 7.2 or higher.

Submitting bugs and feature requests
------------------------------------
Expand All @@ -67,6 +67,9 @@ Author
Changelog
----------

## 3.0.0 (2018-XX-XX)
- [#6](../../pull/6) dropped support for PHP 7.1 as it is no longer supported

## 2.0.0 (2018-01-05)
- [#3](../../pull/3) require PHP 7.1, potential BC breaks because of added type-hints

Expand Down
11 changes: 6 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,16 @@
}
],
"require": {
"php": "~7.1",
"php": "~7.2",
"jms/serializer": "^1.2",
"ramsey/uuid": "~3.0"
},
"require-dev": {
"consistence/coding-standard": "2.3",
"jakub-onderka/php-parallel-lint": "0.9.2",
"phpunit/phpunit": "6.5.5",
"satooshi/php-coveralls": "2.0.0"
"consistence/coding-standard": "3.5",
"jakub-onderka/php-parallel-lint": "1.0.0",
"php-coveralls/php-coveralls": "2.1.0",
"phpunit/phpunit": "7.4.4",
"squizlabs/php_codesniffer": "3.3.2"
},
"autoload": {
"psr-4": { "Mhujer\\JmsSerializer\\": [ "src" ] },
Expand Down
9 changes: 5 additions & 4 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@

<phpunit
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/6.5/phpunit.xsd"
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
bootstrap="tests/bootstrap.php"
colors="true"
failOnRisky="true"
verbose="true"
beStrictAboutChangesToGlobalState="true"
beStrictAboutOutputDuringTests="true"
beStrictAboutTodoAnnotatedTests="true"
beStrictAboutCoversAnnotation="true"
>
>

<testsuites>
<testsuite name="MhujerJmsSerializerUuid Test Suite">
Expand Down
2 changes: 1 addition & 1 deletion tests/Uuid/UuidSerializerHandlerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function testDeserializeInvalidUuid(): void
private function getSerializer(): Serializer
{
return SerializerBuilder::create()
->configureHandlers(function (HandlerRegistry $registry) {
->configureHandlers(function (HandlerRegistry $registry): void {
$registry->registerSubscribingHandler(new UuidSerializerHandler());
})
->build();
Expand Down