Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hide one branch #175

Closed
thmatot opened this issue Sep 5, 2019 · 4 comments
Closed

Ability to hide one branch #175

thmatot opened this issue Sep 5, 2019 · 4 comments
Assignees
Labels
improvement An improvement to existing functionality
Milestone

Comments

@thmatot
Copy link
Contributor

thmatot commented Sep 5, 2019

Select/unselect all branches in dropdown list when clicking on "show all" item.
This will allow to unselect one branch if all item are selected, and select one branch if all branches are unselected

@thmatot thmatot added the improvement An improvement to existing functionality label Sep 5, 2019
@mhutchie
Copy link
Owner

mhutchie commented Sep 5, 2019

Thanks for raising this improvement, it would definitely be useful to be able to “Show All” branches, and then unselect one or more specific branches.

I’ll need to work out the details of exactly how this behaviour should work, as I don’t want to impact the most common use case of the Branches dropdown (switching from “Show All” to a single branch, or vice versa). At the moment this can be done in one step (clicking on the desired branch in the dropdown), however from my understanding of what you’ve suggested, this would now unselect the specific branch from ”Show All”, instead of switching to it.

@thmatot
Copy link
Contributor Author

thmatot commented Sep 5, 2019

What I suggest is :

  • First click on Show all will have the current behavior (all branches unselected in dropdown, if I then click on one branch this branch is shown)
  • Second consecutive click on "show all" (without any click on other branch between) will select all branches in dropdown (Add OK icon on the left of all branches). Then if I click another branch it is unselected and all other branches stay selected

@mhutchie
Copy link
Owner

mhutchie commented Sep 5, 2019

Thanks @thmatot, your suggestion is perfect for allowing both the current behaviour, and the new behaviour of this improvement request to work nicely together (and being quite intuitive for users).

thmatot pushed a commit to thmatot/vscode-git-graph that referenced this issue Sep 6, 2019
…n 'show all' to allow to unselect branch
thmatot added a commit to thmatot/vscode-git-graph that referenced this issue Sep 6, 2019
mhutchie pushed a commit that referenced this issue Sep 9, 2019
@mhutchie mhutchie added this to the v1.15.0 milestone Sep 9, 2019
@mhutchie mhutchie removed their assignment Sep 9, 2019
@mhutchie
Copy link
Owner

mhutchie commented Sep 9, 2019

Thanks again for implementing this functionality! Awesome work!

This will be available in v1.15.0.

If you'd like to use it before the next release, you can download v1.15.0-beta.1, and install it following the instructions provided here.

@mhutchie mhutchie closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants