Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New git.path array option causes error in Git Graph: "Unable to find a Git executable" #392

Closed
charlwillia6 opened this issue Oct 9, 2020 · 2 comments
Assignees
Labels
bug Something isn't working vscode-breaking-change Visual Studio Code introduced a breaking change that affects the extension
Milestone

Comments

@charlwillia6
Copy link

Describe the Bug
VSCode settings now allows git.path to be an array of strings for searching different paths for the git executables. Since vscode-git-graph consumes the git.path setting, this now causes the following error: "Unable to find a Git executable"

Steps to Reproduce
Steps to reproduce the behaviour:

  1. Change git.path in settings.json to git.path: ["C:\\path\\to\\git.exe", "C:\\another\\path\\to\\git.exe"]
  2. Re-open Visual Studio Code
  3. Error appears

Expected Behaviour
Git Graph should recognize arrays for the git.path setting now.

Environment

  • Git Graph Extension Version: v1.26.0
  • Visual Studio Code Version: 1.50.0
  • Operating System: Windows 10

Screenshots (optional)
image

Additional Context (optional)
I realize this is a new feature released in the stable version of VSCode to allow arrays of strings for the git.path setting. I am making Git Graph developers aware of this change to VSCode so that this can be fixed quickly.

@charlwillia6 charlwillia6 added the bug Something isn't working label Oct 9, 2020
@mhutchie mhutchie added the vscode-breaking-change Visual Studio Code introduced a breaking change that affects the extension label Oct 9, 2020
@mhutchie
Copy link
Owner

mhutchie commented Oct 9, 2020

Thanks @charlwillia6 for making me aware of this!

I find it extremely frustrating that the VSCode team just releases breaking changes like this, without notifying extensions that are affected.

Fortunately this shouldn't affect too many users. It will only affect users who:

  • Are new to Git Graph & they already define an array in git.path, as Git Graph won't have cached the last know Git executable. When Visual Studio Code starts up, Git Graph will check if the last known Git executable still exists, and if so, reuse it.
  • Change git.path to the array format while the Git Graph extension is installed.

I'll make a beta release with support for this available within the next 24 hours. I plan on doing a new full release of the extension almost certainly next weekend 18/10/2020, so this change will also be included in it.

@mhutchie mhutchie added this to the v1.27.0 milestone Oct 9, 2020
mhutchie added a commit that referenced this issue Oct 11, 2020
…ray of possible Git executable paths (introduced in Visual Studio Code 1.50.0).
@mhutchie
Copy link
Owner

This will be available in v1.27.0.

If you'd like to use it before the next release, you can download v1.27.0-beta.3, and install it following the instructions provided here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vscode-breaking-change Visual Studio Code introduced a breaking change that affects the extension
Projects
None yet
Development

No branches or pull requests

2 participants