-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix right-click menu being hidden when running in a browser #294
Conversation
Thanks for raising this PR with this context menu change, I’ll test your changes out and merge them! FYI: Up until now I’ve only supported Visual Studio Code installations of the extension, not third-party products. However, if this change enables Git Graph to be used in these products, I’m more than happy to extend support to them. |
Thanks for the extra information. Considering this is the case (which I suspected this morning, but didn’t want to mention until I verified my suspicion), I’ll leave merging this pull request until enough users of Git Graph are using a compatible version of Visual Studio Code for the underlying required functionality. (Hopefully this will be quite soon) I’ll close this pull request until this requirement is met, at which time I’ll reopen and merge this pull request. Thank you again for your work on this item, I really appreciate that you took the time and effort to implement this! |
Hi @tstibbs, Thanks again for raising this PR, it's much appreciated! I've incorporated these right-click changes with several other changes I've identified while testing Git Graph in various web browsers and platforms. I'm just seeking some advice & confirmations from Microsoft regarding some final details. Once I hear back from Microsoft, I'll publish a new beta release with all of these changes. |
Thanks @mhutchie - just to bring this one to a close, can you post a link to the issue/PR which will contain these fixes? If anyone comes here in the future seeing the same problem, it would be useful if they could look at the fix that was applied. |
Git Graph support for Visual Studio Code in web browsers was implemented in the following two commits:
Thanks again @tstibbs for your help with the context menu compatibility issue, it was included among the other required changes in a0d6cc2. |
If running this plugin in a browser (e.g. using theia or gitpod), when you right-click on a commit, git graph's right click menu appears but the browser right click menu appears over the top of it. This PR fixes that by preventing the browser right click menu appearing, allowing you to use git graph's menu as intended.
As far as I can see this change has no negative impact when running natively in VS Code.