Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right-click menu being hidden when running in a browser #294

Closed
wants to merge 1 commit into from

Conversation

tstibbs
Copy link

@tstibbs tstibbs commented Apr 20, 2020

If running this plugin in a browser (e.g. using theia or gitpod), when you right-click on a commit, git graph's right click menu appears but the browser right click menu appears over the top of it. This PR fixes that by preventing the browser right click menu appearing, allowing you to use git graph's menu as intended.

As far as I can see this change has no negative impact when running natively in VS Code.

@tstibbs tstibbs marked this pull request as ready for review April 20, 2020 19:03
@tstibbs tstibbs requested a review from mhutchie as a code owner April 20, 2020 19:03
@mhutchie
Copy link
Owner

Thanks for raising this PR with this context menu change, I’ll test your changes out and merge them!

FYI: Up until now I’ve only supported Visual Studio Code installations of the extension, not third-party products. However, if this change enables Git Graph to be used in these products, I’m more than happy to extend support to them.

@mhutchie mhutchie added this to the v1.23.0 milestone Apr 20, 2020
@tstibbs
Copy link
Author

tstibbs commented Apr 21, 2020

@mhutchie thanks - worth noting that this isn't all you need to get it to run in theia (and therefore gitpod), but with this and #271 it seems to work ok.

@mhutchie mhutchie removed this from the v1.23.0 milestone Apr 21, 2020
@mhutchie mhutchie added the backlog Requests that are closed for now, but may be re-opened in the future if more interest is expressed label Apr 21, 2020
@mhutchie
Copy link
Owner

Thanks for the extra information. Considering this is the case (which I suspected this morning, but didn’t want to mention until I verified my suspicion), I’ll leave merging this pull request until enough users of Git Graph are using a compatible version of Visual Studio Code for the underlying required functionality. (Hopefully this will be quite soon)

I’ll close this pull request until this requirement is met, at which time I’ll reopen and merge this pull request.

Thank you again for your work on this item, I really appreciate that you took the time and effort to implement this!

@mhutchie mhutchie closed this Apr 21, 2020
@tstibbs tstibbs deleted the fixing-right-click branch June 5, 2020 19:09
@tstibbs tstibbs restored the fixing-right-click branch June 6, 2020 06:39
@mhutchie mhutchie removed the backlog Requests that are closed for now, but may be re-opened in the future if more interest is expressed label Jun 7, 2020
@mhutchie
Copy link
Owner

mhutchie commented Jun 8, 2020

Hi @tstibbs, Thanks again for raising this PR, it's much appreciated!

I've incorporated these right-click changes with several other changes I've identified while testing Git Graph in various web browsers and platforms. I'm just seeking some advice & confirmations from Microsoft regarding some final details. Once I hear back from Microsoft, I'll publish a new beta release with all of these changes.

@tstibbs
Copy link
Author

tstibbs commented Jun 8, 2020

Thanks @mhutchie - just to bring this one to a close, can you post a link to the issue/PR which will contain these fixes? If anyone comes here in the future seeing the same problem, it would be useful if they could look at the fix that was applied.

@mhutchie mhutchie linked an issue Jun 13, 2020 that may be closed by this pull request
@mhutchie mhutchie added this to the v1.24.0 milestone Jun 13, 2020
@mhutchie
Copy link
Owner

Git Graph support for Visual Studio Code in web browsers was implemented in the following two commits:

  • Upgraded the minimum version requirement of Visual Studio Code from 1.31.0 to 1.38.0. Migrated to use asWebviewUri & cspSource. faa39dea
  • Support for Visual Studio Code in Web Browsers. a0d6cc2

Thanks again @tstibbs for your help with the context menu compatibility issue, it was included among the other required changes in a0d6cc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Browser Support for Git Graph
2 participants